Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't crash when nativeImage.createFromBuffer() is called with invalid buffer (backport: 4-0-x) #17373

Merged
merged 1 commit into from Mar 19, 2019
Merged

fix: don't crash when nativeImage.createFromBuffer() is called with invalid buffer (backport: 4-0-x) #17373

merged 1 commit into from Mar 19, 2019

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Mar 13, 2019

Backport of #17344

See that PR for details.

Notes: Fixed crash when nativeImage.createFromBuffer() is called with invalid buffer.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 13, 2019
@trop trop bot mentioned this pull request Mar 13, 2019
Merged
5 tasks
@trop trop bot added 4-2-x backport This is a backport PR labels Mar 13, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 13, 2019
MarshallOfSound
MarshallOfSound requested changes Mar 13, 2019
View reviewed changes
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking pending 4.1

@MarshallOfSound MarshallOfSound changed the base branch from 4-0-x to 4-1-x March 19, 2019 19:13
MarshallOfSound
MarshallOfSound approved these changes Mar 19, 2019
View reviewed changes
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging into 4-1-x

@MarshallOfSound MarshallOfSound merged commit 5e665c1 into electron:4-1-x Mar 19, 2019
@release-clerk
Copy link

release-clerk bot commented Mar 19, 2019

Release Notes Persisted

Fixed crash when nativeImage.createFromBuffer() is called with invalid buffer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
4-2-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @MarshallOfSound @miniak