Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backport KDE icon size fix #17497

Merged
merged 1 commit into from Mar 21, 2019
Merged

fix: backport KDE icon size fix #17497

merged 1 commit into from Mar 21, 2019

Conversation

MarshallOfSound
Copy link
Member

The code that adds padding to too small icons was breaking the larger ones by cutting the minimal size (22x22px) out of their center.

Backports: https://chromium-review.googlesource.com/c/chromium/src/+/1173235

Release Notes

Notes: Fixed issue on KDE where tray icons would be displayed incorrectly as a 22x22 version of the provided tray image but cropped from the center

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 21, 2019
@MarshallOfSound MarshallOfSound changed the title [WIP] fix: backport KDE icon size fix fix: backport KDE icon size fix Mar 21, 2019
@ckerr ckerr merged commit 7b1f5a9 into 4-1-x Mar 21, 2019
@release-clerk
Copy link

release-clerk bot commented Mar 21, 2019

Release Notes Persisted

Fixed issue on KDE where tray icons would be displayed incorrectly as a 22x22 version of the provided tray image but cropped from the center

@ckerr ckerr deleted the backport-kde-icon-fix branch March 21, 2019 19:19
@MarshallOfSound MarshallOfSound removed the new-pr 🌱 PR opened in the last 24 hours label Mar 21, 2019
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 21, 2019
@MarshallOfSound MarshallOfSound removed the new-pr 🌱 PR opened in the last 24 hours label Mar 21, 2019
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4-2-x new-pr 🌱 PR opened in the last 24 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants