Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: backport [IntersectionObserver] Report coordinates as CSS pixels #17583

Merged
merged 1 commit into from Mar 29, 2019
Merged

fix: backport [IntersectionObserver] Report coordinates as CSS pixels #17583

merged 1 commit into from Mar 29, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Mar 27, 2019 •
edited by alexeykuzmin

Description of Change

Backport https://chromium-review.googlesource.com/c/chromium/src/+/1250121/

[IntersectionObserver] Report coordinates as CSS pixels.
Prior to this patch, IntersectionObserverEntry was reporting coordinates in device pixels.

Checklist

Release Notes

Notes: Fixed IntersectionObserver.rootBounds for navigator zoom != 100%

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 27, 2019
@miniak miniak self-assigned this Mar 27, 2019
@miniak miniak marked this pull request as ready for review March 27, 2019 22:53
@deepak1556 deepak1556 requested a review from a team March 28, 2019 15:01
@miniak miniak force-pushed the miniak/intersection-observer-4-1-x branch from f8125c3 to fabe20c Compare March 28, 2019 22:10
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 28, 2019
@alexeykuzmin
Copy link
Contributor

Commit c02251d2... initially landed in 71.0.3565.0

It's ok to backport to the 4-1-x only 👍

@alexeykuzmin alexeykuzmin merged commit 3001c76 into 4-1-x Mar 29, 2019
@release-clerk
Copy link

release-clerk bot commented Mar 29, 2019 •
edited by alexeykuzmin

Release Notes Persisted

Fixed IntersectionObserver.rootBounds for navigator zoom != 100%

@alexeykuzmin alexeykuzmin deleted the miniak/intersection-observer-4-1-x branch March 29, 2019 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeykuzmin alexeykuzmin alexeykuzmin approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

@codebytere codebytere codebytere approved these changes

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees

@miniak miniak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@miniak @alexeykuzmin @deepak1556 @codebytere