Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Issue 888678: Heap-use-after-free in content::KeyboardLockServiceImpl::GetKeyboardLayoutMap #17632

Merged
merged 1 commit into from Apr 2, 2019
Merged

fix: Issue 888678: Heap-use-after-free in content::KeyboardLockServiceImpl::GetKeyboardLayoutMap #17632

merged 1 commit into from Apr 2, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Mar 31, 2019 •
edited

Description of Change

Backport fix for https://bugs.chromium.org/p/chromium/issues/detail?id=888678
https://chromium-review.googlesource.com/c/chromium/src/+/1246290/

Destroy KeyboardLockServiceImpl instance when RenderFrameHost goes away

This CL updates KeyboardLockServiceImpl to release its mojo binding if
the RenderFrameHost instance it is linked to is destroyed.

Checklist

Release Notes

Notes: Backported fix for https://bugs.chromium.org/p/chromium/issues/detail?id=888678.

/cc @electron/wg-security

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 31, 2019
@miniak miniak self-assigned this Mar 31, 2019
@miniak miniak requested a review from a team March 31, 2019 18:43
@miniak miniak marked this pull request as ready for review March 31, 2019 18:43
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 1, 2019
@MarshallOfSound MarshallOfSound merged commit bcdc443 into 4-1-x Apr 2, 2019
@release-clerk
Copy link

release-clerk bot commented Apr 2, 2019

Release Notes Persisted

Backported fix for https://bugs.chromium.org/p/chromium/issues/detail?id=888678.

@miniak miniak deleted the miniak/keyboard-lock-service-impl-4-1-x branch April 2, 2019 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeykuzmin alexeykuzmin alexeykuzmin approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees

@miniak miniak

Labels
4-2-x security 🔒
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@miniak @alexeykuzmin @deepak1556 @MarshallOfSound