Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Issue 914497: QUIC proxying breaks end-to-end encryption #17634

Merged
merged 1 commit into from Jun 3, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Mar 31, 2019

Description of Change

Backport fix for https://bugs.chromium.org/p/chromium/issues/detail?id=914497
https://chromium.googlesource.com/chromium/src.git/+/cd92d8fb7eab1c9b5a7a99bc804718157dbe7da3

Disable the use of QUIC proxies for https:// URLs.

This is a partial revert of https://chromium-review.googlesource.com/c/chromium/src/+/858603

https://chromium.googlesource.com/chromium/src.git/+/4cbcbf17db00a0011b5d232617d25db0cd3bee10

Re-enable support for sending HTTPS URLs via QUIC proxies, but only when
the finch param enable_quic_proxies_for_https_urls is set.

This effectively reverts https://chromium-review.googlesource.com/c/chromium/src/+/1375112
and then fixes the underlying bug.

https://chromium.googlesource.com/chromium/src.git/+/fd2335678e96c34d14f4b20f0d9613dfbd1ccdb4

Fix a bug in network_session_configurator.cc in which support for HTTPS URLS in QUIC proxies was always set to false.

/cc @electron/wg-security

Checklist

Release Notes

Notes: Backported fix for https://bugs.chromium.org/p/chromium/issues/detail?id=914497.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 31, 2019
@miniak miniak force-pushed the miniak/enable_quic_proxies_for_https_urls-4-1-x branch from eb51ec2 to 2affe62 Compare March 31, 2019 19:55
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 1, 2019
@miniak miniak changed the base branch from miniak/keyboard-lock-service-impl-4-1-x to 4-1-x April 2, 2019 14:41
@miniak miniak force-pushed the miniak/enable_quic_proxies_for_https_urls-4-1-x branch from 2affe62 to ee0bf57 Compare April 2, 2019 14:41
@miniak miniak force-pushed the miniak/enable_quic_proxies_for_https_urls-4-1-x branch from ee0bf57 to 8ec2980 Compare May 30, 2019 22:12
@miniak miniak requested a review from a team May 30, 2019 22:14
@miniak miniak changed the base branch from 4-1-x to 4-2-x May 30, 2019 22:17
@miniak miniak self-assigned this May 30, 2019
@miniak miniak added 4-2-x backport This is a backport PR labels May 30, 2019
@miniak miniak marked this pull request as ready for review May 30, 2019 22:34
Date: Sun, 31 Mar 2019 21:12:59 +0200
Subject: =?UTF-8?q?Enable=20support=20for=20sending=20HTTPS=20URLs=20via?=
=?UTF-8?q?=20QUIC=20proxies=20only=20when=0Athe=20finch=20param=20enable?=
=?UTF-8?q?=5Fquic=5Fproxies=5Ffor=5Fhttps=5Furls=20is=20set.?=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's quite a subject line

@miniak miniak removed the backport This is a backport PR label May 31, 2019
@miniak miniak added security 🔒 backport This is a backport PR labels Jun 3, 2019
@nornagon nornagon merged commit 7976494 into 4-2-x Jun 3, 2019
@release-clerk
Copy link

release-clerk bot commented Jun 3, 2019

Release Notes Persisted

Backported fix for https://bugs.chromium.org/p/chromium/issues/detail?id=914497.

@nornagon nornagon deleted the miniak/enable_quic_proxies_for_https_urls-4-1-x branch June 3, 2019 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants