Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update fix_font_thickness.patch #17737

Merged
merged 1 commit into from Apr 15, 2019
Merged

fix: update fix_font_thickness.patch #17737

merged 1 commit into from Apr 15, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Apr 9, 2019 •
edited

Description of Change

Backport https://skia-review.googlesource.com/c/skia/+/177880, follow up to #15007

Checklist

Release Notes

Notes: Back-ported additional fix for font rendering in MacOS Mojave.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 9, 2019
@miniak miniak self-assigned this Apr 9, 2019
@miniak miniak requested review from codebytere, nornagon and deepak1556 and removed request for codebytere April 9, 2019 17:37
@miniak miniak marked this pull request as ready for review April 9, 2019 17:41
@miniak miniak mentioned this pull request Apr 9, 2019
Merged
4 tasks
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 10, 2019
@MarshallOfSound MarshallOfSound merged commit d2bff97 into 4-1-x Apr 15, 2019
@release-clerk
Copy link

release-clerk bot commented Apr 15, 2019

Release Notes Persisted

Back-ported additional fix for font rendering in MacOS Mojave.

@MarshallOfSound MarshallOfSound deleted the miniak/fix_font_thickness-4-1-x branch April 15, 2019 23:53
@dalDevelo
Copy link

dalDevelo commented Apr 25, 2019 •
edited

This is not fixed in 4.1.5 😢. Screen shots below of VSCode exploration using 4.1.5, with CGFontRenderingFontSmoothingDisabled set to both YES and NO...

CGFontRenderingFontSmoothingDisabled YES

CGFontRenderingFontSmoothingDisabled NO

feint
clear

@dalDevelo dalDevelo mentioned this pull request Apr 29, 2019
Merged
3 tasks
@svipas
Copy link

svipas commented May 3, 2019 •
edited

@dalDevelo I tried to use the latest VS Code exploration build from here: microsoft/vscode#73119 and it was the same, I don't see any difference.

@miniak Maybe you know why the font is the same as it's in VS Code which is using Electron 4.1.5? I expected it to be a little different, but it's the same as it's with Electron 3.1.6.

@dalDevelo dalDevelo mentioned this pull request May 25, 2019
Closed
@lexi-lambda lexi-lambda mentioned this pull request Aug 27, 2019
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@codebytere codebytere Awaiting requested review from codebytere

@deepak1556 deepak1556 Awaiting requested review from deepak1556

Assignees

@miniak miniak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@miniak @dalDevelo @svipas @nornagon @MarshallOfSound