Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reset the NSUserNotication handle on dismiss (backport: 4-1-x) #17821

Merged
merged 1 commit into from Apr 16, 2019
Merged

fix: reset the NSUserNotication handle on dismiss (backport: 4-1-x) #17821

merged 1 commit into from Apr 16, 2019

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Apr 16, 2019

Backport of #17796

See that PR for details.

Notes: Fix crash when manually dismissing notifications before quit on macOS

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 16, 2019
@trop trop bot mentioned this pull request Apr 16, 2019
Merged
@trop trop bot added 4-2-x backport This is a backport PR labels Apr 16, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 16, 2019
@codebytere codebytere merged commit 40c7e76 into electron:4-1-x Apr 16, 2019
@release-clerk
Copy link

release-clerk bot commented Apr 16, 2019

Release Notes Persisted

Fix crash when manually dismissing notifications before quit on macOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
4-2-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @MarshallOfSound