Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: document occasional mismatch between NSImageName and string (backport: 4-1-x) #17848

Merged
merged 1 commit into from Apr 18, 2019
Merged

docs: document occasional mismatch between NSImageName and string (backport: 4-1-x) #17848

merged 1 commit into from Apr 18, 2019

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Apr 17, 2019

Backport of #17826

See that PR for details.

Notes: Documented an issue with nativeImage.createFromNamedImage where the string representations of NSImageName might not match the NSImageName.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 17, 2019
@trop trop bot mentioned this pull request Apr 17, 2019
Merged
4 tasks
@trop trop bot added 4-2-x backport This is a backport PR labels Apr 17, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 17, 2019
@MarshallOfSound MarshallOfSound merged commit 4175e94 into electron:4-1-x Apr 18, 2019
@release-clerk
Copy link

release-clerk bot commented Apr 18, 2019

Release Notes Persisted

Documented an issue with nativeImage.createFromNamedImage where the string representations of NSImageName might not match the NSImageName.

@MarshallOfSound
Copy link
Member

/trop run backport-to 3-1-x

@trop
Copy link
Contributor Author

trop bot commented Apr 19, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "3-1-x" here we go! :D

@trop
Copy link
Contributor Author

trop bot commented Apr 19, 2019

I was unable to backport this PR to "3-1-x" cleanly;
you will need to perform this backport manually.

@MarshallOfSound
Copy link
Member

/trop run backport-to 3-1-x

@trop
Copy link
Contributor Author

trop bot commented Apr 19, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "3-1-x" here we go! :D

@trop trop bot mentioned this pull request Apr 19, 2019
Closed
@trop
Copy link
Contributor Author

trop bot commented Apr 19, 2019

I have automatically backported this PR to "3-1-x", please check out #17871

@trop trop bot added the in-flight/3-1-x label Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
4-2-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MarshallOfSound @codebytere