Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: copy pixels in AddImageSkiaRepFromBuffer (4-1-x) #17862

Merged
merged 1 commit into from Apr 18, 2019
Merged

fix: copy pixels in AddImageSkiaRepFromBuffer (4-1-x) #17862

merged 1 commit into from Apr 18, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Apr 18, 2019 •
edited

Description of Change

Backport of #17843

Checklist

Release Notes

Notes: Fixed inconsistent behavior where modifying the buffer would change nativeImage pixels, while decoded PNG / JPEG data is a copy.

@miniak miniak self-assigned this Apr 18, 2019
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 18, 2019
@trop trop bot mentioned this pull request Apr 18, 2019
Merged
4 tasks
@codebytere codebytere added 4-2-x backport This is a backport PR labels Apr 18, 2019
@codebytere codebytere merged commit 2360f3e into 4-1-x Apr 18, 2019
@release-clerk
Copy link

release-clerk bot commented Apr 18, 2019

Release Notes Persisted

Fixed inconsistent behavior where modifying the buffer would change nativeImage pixels, while decoded PNG / JPEG data is a copy.

@codebytere codebytere deleted the miniak/native-image-4-1-x branch April 18, 2019 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees

@miniak miniak

Labels
4-2-x backport This is a backport PR new-pr 🌱 PR opened in the last 24 hours
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@miniak @codebytere