Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: crash when run from SMB network share #17908

Merged
merged 1 commit into from Apr 24, 2019
Merged

fix: crash when run from SMB network share #17908

merged 1 commit into from Apr 24, 2019

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Apr 23, 2019

Backport of #17886

See that PR for details.

Notes: Fixed crash when Electron run from SMB network share.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 23, 2019
@trop trop bot mentioned this pull request Apr 23, 2019
Merged
4 tasks
@trop trop bot added 5-0-x backport This is a backport PR labels Apr 23, 2019
codebytere
codebytere requested changes Apr 23, 2019
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@electron/wg-releases let's hold this one for 5.0.1

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 23, 2019
codebytere
codebytere approved these changes Apr 24, 2019
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v5.0.0 has been released!

@codebytere codebytere merged commit f3a05c3 into 5-0-x Apr 24, 2019
@release-clerk
Copy link

release-clerk bot commented Apr 24, 2019

Release Notes Persisted

Fixed crash when Electron run from SMB network share.

@codebytere codebytere deleted the trop/5-0-x-bp-fix-crash-when-run-from-smb-network-share-1555986548867 branch April 24, 2019 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
5-0-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@codebytere