Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: explicitly focus window on win.show() #18080

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Apr 30, 2019

Backport of #18046

See that PR for details.

Notes: Fixed an issue on Windows where calling .show() on a BrowserWindow did not focus the window.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 30, 2019
@trop trop bot mentioned this pull request Apr 30, 2019
4 tasks
@trop trop bot added 5-0-x backport This is a backport PR labels Apr 30, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 30, 2019
@codebytere codebytere merged commit 232d9fe into 5-0-x May 1, 2019
@release-clerk
Copy link

release-clerk bot commented May 1, 2019

Release Notes Persisted

Fixed an issue on Windows where calling .show() on a BrowserWindow did not focus the window.

@codebytere codebytere deleted the trop/5-0-x-bp-fix-explicitly-focus-window-on-win-show--1556667845414 branch May 1, 2019 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5-0-x backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant