Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not mark navigations interupted with same-document navigations as aborted #18142

Merged
merged 2 commits into from May 4, 2019
Merged

fix: do not mark navigations interupted with same-document navigations as aborted #18142

merged 2 commits into from May 4, 2019

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented May 3, 2019

Backport of #18109

See that PR for details.

Notes: Fixed case where the promise returned by loadURL and loadFile would be rejected with ERR_ABORTED if you triggered a virtual navigation before the page had finished loading. E.g. Used history.pushState or set location.hash

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 3, 2019
@trop trop bot mentioned this pull request May 3, 2019
Merged
@trop trop bot added 5-0-x backport This is a backport PR labels May 3, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 3, 2019
@codebytere codebytere merged commit 82bb6d4 into 5-0-x May 4, 2019
@release-clerk
Copy link

release-clerk bot commented May 4, 2019

Release Notes Persisted

Fixed case where the promise returned by loadURL and loadFile would be rejected with ERR_ABORTED if you triggered a virtual navigation before the page had finished loading. E.g. Used history.pushState or set location.hash

@codebytere codebytere deleted the trop/5-0-x-bp-fix-do-not-mark-navigations-interupted-with-same-document-navigations-as-aborted-1556925611039 branch May 4, 2019 06:09
@miniak
Copy link
Contributor

miniak commented Jun 7, 2019

@codebytere this PR introduced a linter error due to unused variable:

npm run lint

> electron@5.0.3 lint /Volumes/Builds/github/electron-5.0/src/electron
> node ./script/lint.js && npm run lint:clang-format && npm run lint:docs


/Volumes/Builds/github/electron-5.0/src/electron/spec/api-browser-window-spec.js
  309:13  error  'data' is assigned a value but never used  no-unused-vars

✖ 1 problem (1 error, 0 warnings)

can you please fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
5-0-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miniak @codebytere @MarshallOfSound