Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop falling back sans-serif to SimSun and (P)MingLiu #18193

Closed
be5invis opened this issue May 7, 2019 · 4 comments
Closed

Stop falling back sans-serif to SimSun and (P)MingLiu #18193

be5invis opened this issue May 7, 2019 · 4 comments
Labels
blocked/need-info ❌ Cannot proceed without more information

Comments

@be5invis
Copy link
Contributor

be5invis commented May 7, 2019

SimSun and PMingLiu are serif fonts, they should not be used as the fallback font for sans-serif families.

image

ref. https://www.zhihu.com/question/323244457/answer/675834621

@nornagon
Copy link
Member

nornagon commented May 7, 2019

Thanks for reaching out!

We require the template to be filled out on all new issues and pull requests. We do this so that we can be certain we have all the information we need to address your submission efficiently. This allows the maintainers to spend more time fixing bugs, implementing enhancements, and reviewing and merging pull requests.

Thanks for understanding and meeting us half way 😀

@nornagon nornagon added the blocked/need-info ❌ Cannot proceed without more information label May 7, 2019
@be5invis be5invis closed this as completed May 7, 2019
@ShikiSuen

This comment has been minimized.

@ShikiSuen
Copy link

Additionally, @be5invis works in Microsoft and is making efforts to improve the CJK font experience of Microsoft products. He surely knows that the CJK font fallback behavior of popular softwares on Microsoft Windows can directly affect the user experience of Microsoft products in Simplified Chinese / Traditional Chinese / Japanese / Korean languages.

Behaviors of misusing types of UI font for a language is making trouble to the users who use this language. Chromium currently does this stupidly by prioritizing PMingLiU & SimSun (serif Chinese fonts) above Micrsoft YaHei and JhengHei (sans-serif Chinese fonts) [1]. To be frank, using "sans-serif" is enough in current Windows 10 builds. Is Electron still gonna do the same stupid thing?

[1] See: https://cs.chromium.org/chromium/src/third_party/blink/renderer/platform/fonts/win/font_fallback_win.cc

  static const UChar* const kSimplifiedHanFonts[] = {L"simsun",
                                                     L"Microsoft YaHei", 0};
  static const UChar* const kTraditionalHanFonts[] = {L"pmingliu",
                                                      L"Microsoft JhengHei", 0};

@nornagon
Copy link
Member

nornagon commented May 8, 2019

This issue was re-opened as #18197, please continue discussion there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked/need-info ❌ Cannot proceed without more information
Projects
None yet
Development

No branches or pull requests

3 participants