Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lagging when using tabbed window (4-2-x) #18314

Merged
merged 1 commit into from May 16, 2019

Conversation

zcbenz
Copy link
Member

@zcbenz zcbenz commented May 16, 2019

Description of Change

Fix lagging when using tabbed windows, close #16925.

This problem only happens for 4.x so I'm only patching 4-2-x branch.

Later Chromium has some enhancements on graphics code that fix the lagging problem, but the changes are split in multiple commits on multiple files and we can not just cherry-pick them.

Instead I'm just using the dummy fix and it does not seem to have side effects.

Checklist

Release Notes

Notes: Fix lagging when using tabbed window.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 16, 2019
@zcbenz zcbenz requested a review from deepak1556 May 16, 2019 05:02
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MarshallOfSound MarshallOfSound added the fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases label May 16, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 16, 2019
@MarshallOfSound MarshallOfSound merged commit 7521454 into 4-2-x May 16, 2019
@MarshallOfSound MarshallOfSound deleted the fix-lagging-for-tabbed-window branch May 16, 2019 21:20
@release-clerk
Copy link

release-clerk bot commented May 16, 2019

Release Notes Persisted

Fix lagging when using tabbed window.

@pixieaka
Copy link

Finally done 👍 Great work guys 🎉
All the best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4-2-x fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases performance 🏁 platform/macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants