Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 'page-title-updated' event forwarding + documentation #18318

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented May 16, 2019

Backport of #18270

See that PR for details.

Notes: Added missing 'page-title-updated' event on webContents to documentation. Also fixed forwarding of the explicitSet argument when emitted on BrowserWindow.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 16, 2019
@trop trop bot added 5-0-x backport This is a backport PR labels May 16, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 16, 2019
@zcbenz zcbenz merged commit 7ee06c3 into 5-0-x May 21, 2019
@release-clerk
Copy link

release-clerk bot commented May 21, 2019

Release Notes Persisted

Added missing 'page-title-updated' event on webContents to documentation. Also fixed forwarding of the explicitSet argument when emitted on BrowserWindow.

@zcbenz zcbenz deleted the trop/5-0-x-bp-fix-page-title-updated-event-forwarding-documentation-1557999211206 branch May 21, 2019 07:22
@AnalyzerTech
Copy link

(^__^))}{"HelloWorld"};
I did the unthinkable, and it was the biggest argument I have been in on line.
I sent a personal document to a site in a conversation that was in a navigating chat box.
I was not getting a response and I got concerned so like usual I inspect element and the argument takes
off in full effect. I began losing leverage and control over the argument so I left out of anger and in my return I see violation of using up space but I really needed to clear my head. after my break I eventually had to request IANA for help do to more than one force involved with the issue. If I leave a problem unsolved especially when it involves application and data management it gets serious. My 10 months of learning code has really shown me how to view the bigger picture of an event or a technical situation.
well, anyone who reads this message, remember their is always a way to overcome your mistakes and don't ever give up on success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5-0-x backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants