Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<input type=file> is not working on Windows. #18406

Closed
3 tasks done
agata opened this issue May 22, 2019 · 4 comments · Fixed by #18492
Closed
3 tasks done

<input type=file> is not working on Windows. #18406

agata opened this issue May 22, 2019 · 4 comments · Fixed by #18492
Assignees

Comments

@agata
Copy link

agata commented May 22, 2019

Preflight Checklist

  • I have read the Contributing Guidelines for this project.
  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

  • Electron Version:
    • 6.0.0-beta.4
  • Operating System:
    • Windows 10(1809) 64bit
  • Last Known Working Electron version:
    • 5.0.1

Expected Behavior

Can not select local file using .

Actual Behavior

Can select local file using .

To Reproduce

  1. Run this commands.
$ git clone https://github.com/agata/can-not-select-file.git
$ cd can-not-select-file
$ npm install
$ npm start

or download Installer for the sample app. Then Install and run it.

  1. The app shows mozilla's page with example for .

  2. Click "Choose File" and select a local file. It can not select file. It keeps to show "No file choosen."

Screenshots

electron-6 0 0-beta 4

Screeencast: Electron-6.0.0-beta.4.mov.zip

Additional Information

  • Can select a file on Mac OS + Electron 6.0.0-beta.4.
  • Can select a file on Mac OS + Electron 5.0.1.
  • Can select a file on Windows 10 + Electron 5.0.1.
  • Can not select a file on Windows 10 + Electron 6.0.0-beta.4.

I couldn't use the fiel open dialog on Electron 6.0.0-beta.3. Because beta.3 has this issue . It was fixed the issue by Electron 6.0.0-beta.4.

@MarshallOfSound
Copy link
Member

Thanks for the detailed report, really appreciate it 👍

This was fixed in #18383 and will be released in the next 6.0.0 beta release 👍

@agata
Copy link
Author

agata commented May 27, 2019

@MarshallOfSound I've checked Release Notes for v6.0.0-beta.4. The release is including #18383 . But it didn't fix this issue. My sample for reproducing already use the version. https://github.com/agata/can-not-select-file/blob/master/package.json#L21

Could you please check again.

@agata
Copy link
Author

agata commented May 29, 2019

@MarshallOfSound

Please reopen this issue. I checked #18383 . #18383 is for saveDialog. This issue is for openDialog. This issue didn't fix yet. Probably we should fix below line for openDialog the same way.

base::BindOnce(&OnDialogOpened, std::move(promise), result, paths));

to

base::BindOnce(&OnDialogOpened, std::move(promise), !result, paths));

cc: @codebytere

@newPromise
Copy link

I have some question on macOs Catalina, last electron version is v5.02, when you click to select the local
file, the electron app is crashed no reason. then I update electron version to v6.0.12 and the question solved
you can update electron version to v6.0.12 to solve this question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants