Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: populate phase of WebMouseWheelEvents in webContents.sendInputEvent #18494

Merged
merged 1 commit into from May 30, 2019
Merged

fix: populate phase of WebMouseWheelEvents in webContents.sendInputEvent #18494

merged 1 commit into from May 30, 2019

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented May 29, 2019

Backport of #17757

See that PR for details.

Notes: Using webContents.sendInputEvent to send a WebMouseWheelEvent now has the expected effect.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 29, 2019
@trop trop bot mentioned this pull request May 29, 2019
Merged
4 tasks
@trop trop bot added 4-2-x backport This is a backport PR labels May 29, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 29, 2019
@miniak miniak requested a review from a team May 30, 2019 15:35
@ckerr ckerr merged commit 86714c0 into 4-2-x May 30, 2019
@release-clerk
Copy link

release-clerk bot commented May 30, 2019

Release Notes Persisted

Using webContents.sendInputEvent to send a WebMouseWheelEvent now has the expected effect.

@ckerr ckerr deleted the trop/4-2-x-bp-fix-populate-phase-of-webmousewheelevents-in-webcontents-sendinputevent-1559104926888 branch May 30, 2019 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

Assignees
No one assigned
Labels
4-2-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ckerr @ppontes