Sandbox inside ppapi don't inherit sanbox property from BrowserWindow

[Feverqwe]

Hello. I run BrowserWindow with sandbox false and when run ppapi plugin inside, it runing inside sandbox.

Preflight Checklist

• I have read the Contributing Guidelines for this project.
• I agree to follow the Code of Conduct that this project adheres to.
• I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

• Electron Version:
  • 5.0.2
• Operating System:
  • Windows 10 (1903)
• Last Known Working Electron version:
  • 4.2.2

Expected Behavior

ppapi process must inheret --no-sandbox switch

Actual Behavior

ppapi process don't inheret --no-sandbox switch when BrowserWindow have sandbox: false property.

To Reproduce

Create window and run any ppapi plugin inside

new BrowserWindow({
      ...
      webPreferences: {
         sandbox: false
      }
    });

Additional Information

I can fix it with this switch, but is disable sandbox globally.

      electron.app.commandLine.appendSwitch('no-sandbox');

[miniak]

@Feverqwe Why is that a problem?

[Feverqwe]

@miniak cause ppapi plugins don't works. I can't disable sandbox for window, I can only disable it globally.

[miniak]

@Feverqwe which plugin? The only plugins that would not work with sandbox are host-native ones built as plain DLL that don't exclusively use the Pepper API.

[Feverqwe]

I use mpv.js from here https://github.com/Kagami/mpv.js
if I don't use no-sandbox switch I see black block.

[miniak]

@Feverqwe the proper solution IMO in this case is to add a new API to opt-out of sandboxing for a particular plugin. See PR #18939

[miniak]

code example would be

const {PLUGIN_MIME_TYPE} = require("mpv.js");
app.disablePluginSandbox(PLUGIN_MIME_TYPE);

[Feverqwe]

Its looks great! Thx!

[miniak]

@Feverqwe the only problem is that this is semver minor and we'll be only able to add this to Electron 6, which is still in beta. For Electron 5, we would have to bump 5.0 to 5.1 in order to add a new API there.

[Feverqwe]

@miniak its not a problem for me. I resolve this problem via switch, after release I will use this api method.

[electron-triage]

Closing this issue as it is reported to be fixed. Feel free to reach out if you are still experiencing this issue in later versions of Electron and we can reopen.