Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Issue 924843: DCHECK failure in IsAligned(DistanceTo(target), kInstrSize) in instructions-arm64.cc #18530

Merged
merged 2 commits into from Jun 6, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented May 30, 2019

Description of Change

Backport fix for https://bugs.chromium.org/p/chromium/issues/detail?id=924843
https://chromium.googlesource.com/v8/v8.git/+/3af3c9d100cafa27edab30f13f1f9e37be779f15

[Liftoff] Correctly unuse Labels

On Liftoff bailout, instead of binding all unbound labels (to avoid
triggering DCHECKS in their destructor), just Unuse them.

/cc @electron/wg-security

Checklist

Release Notes

Notes: Backported fix for https://bugs.chromium.org/p/chromium/issues/detail?id=924843.

@miniak miniak requested a review from a team May 30, 2019 22:09
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 30, 2019
@miniak miniak self-assigned this May 30, 2019
@miniak miniak changed the title fix: [Liftoff] Correctly unuse Labels fix: Issue 924843: DCHECK failure in IsAligned(DistanceTo(target), kInstrSize) in instructions-arm64.cc May 30, 2019
@miniak miniak added 4-2-x backport This is a backport PR labels May 30, 2019
@miniak miniak marked this pull request as ready for review May 30, 2019 22:32
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 30, 2019
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the fix only went in 74, is it not needed for 5.0.x ?

@miniak
Copy link
Contributor Author

miniak commented May 31, 2019

@deepak1556 are you sure? the ticket says M-71

@deepak1556
Copy link
Member

I didn't check the issue, just the CL's commit https://chromiumdash.appspot.com/commit/3af3c9d100cafa27edab30f13f1f9e37be779f15

@miniak miniak removed the backport This is a backport PR label May 31, 2019
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 31, 2019
@miniak
Copy link
Contributor Author

miniak commented May 31, 2019

@deepak1556 you're right, needs to be backported to 5.0 as well. #18545

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 31, 2019
@miniak miniak added security 🔒 backport This is a backport PR labels Jun 3, 2019
@miniak miniak force-pushed the miniak/liftoff-correctly-unuse-labels-4-2-x branch from 4585149 to b4b6843 Compare June 5, 2019 09:38
@miniak
Copy link
Contributor Author

miniak commented Jun 6, 2019

@codebytere ready to merge

@codebytere codebytere merged commit b7c49f7 into 4-2-x Jun 6, 2019
@codebytere codebytere deleted the miniak/liftoff-correctly-unuse-labels-4-2-x branch June 6, 2019 15:29
@release-clerk
Copy link

release-clerk bot commented Jun 6, 2019

Release Notes Persisted

Backported fix for https://bugs.chromium.org/p/chromium/issues/detail?id=924843.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants