New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Issue 924843: DCHECK failure in IsAligned(DistanceTo(target), kInstrSize) in instructions-arm64.cc #18530
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the fix only went in 74, is it not needed for 5.0.x ?
@deepak1556 are you sure? the ticket says M-71 |
I didn't check the issue, just the CL's commit https://chromiumdash.appspot.com/commit/3af3c9d100cafa27edab30f13f1f9e37be779f15 |
@deepak1556 you're right, needs to be backported to 5.0 as well. #18545 |
4585149
to
b4b6843
Compare
@codebytere ready to merge |
Release Notes Persisted
|
Description of Change
Backport fix for https://bugs.chromium.org/p/chromium/issues/detail?id=924843
https://chromium.googlesource.com/v8/v8.git/+/3af3c9d100cafa27edab30f13f1f9e37be779f15
/cc @electron/wg-security
Checklist
npm test
passesRelease Notes
Notes: Backported fix for https://bugs.chromium.org/p/chromium/issues/detail?id=924843.