Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Issue 924843: DCHECK failure in IsAligned(DistanceTo(target), kInstrSize) in instructions-arm64.cc #18545

Merged
merged 1 commit into from Jun 15, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented May 31, 2019

Description of Change

Backport fix for https://bugs.chromium.org/p/chromium/issues/detail?id=924843
https://chromium.googlesource.com/v8/v8.git/+/3af3c9d100cafa27edab30f13f1f9e37be779f15

[Liftoff] Correctly unuse Labels

On Liftoff bailout, instead of binding all unbound labels (to avoid
triggering DCHECKS in their destructor), just Unuse them.

/cc @electron/wg-security

Checklist

Release Notes

Notes: Backported fix for https://bugs.chromium.org/p/chromium/issues/detail?id=924843.

@miniak miniak added the 5-0-x label May 31, 2019
@miniak miniak requested a review from a team May 31, 2019 12:28
@miniak miniak self-assigned this May 31, 2019
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 31, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 1, 2019
@miniak miniak added security 🔒 backport This is a backport PR labels Jun 3, 2019
@miniak miniak force-pushed the miniak/liftoff-correctly-unuse-labels-5-0-x branch from d5607e9 to 20fabab Compare June 5, 2019 09:36
@zcbenz zcbenz merged commit 183c687 into 5-0-x Jun 15, 2019
@release-clerk
Copy link

release-clerk bot commented Jun 15, 2019

Release Notes Persisted

Backported fix for https://bugs.chromium.org/p/chromium/issues/detail?id=924843.

@zcbenz zcbenz deleted the miniak/liftoff-correctly-unuse-labels-5-0-x branch June 15, 2019 10:42
@sofianguy sofianguy added this to Fixed in 5.0.5 in 5.0.x Jun 21, 2019
@philmenow
Copy link

Root my phone please thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
5.0.x
Fixed in 5.0.5
Development

Successfully merging this pull request may close these issues.

None yet

4 participants