Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: contractions handling in spellchecker (5-0-x) #18548

Merged
merged 1 commit into from Jun 8, 2019
Merged

fix: contractions handling in spellchecker (5-0-x) #18548

merged 1 commit into from Jun 8, 2019

Conversation

code-elf
Copy link
Contributor

Backport of #18506

Notes: Spellcheck providers are now (again) called with contractions and their parts

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 31, 2019
@trop trop bot mentioned this pull request May 31, 2019
Merged
6 tasks
@codebytere codebytere requested a review from nitsakh May 31, 2019 16:47
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 1, 2019
@codebytere
Copy link
Member

Failing linux test:

Notification module (dbus) Notification module using org.freedesktop.Notifications should call org.freedesktop.Notifications to show notifications - should call org.freedesktop.Notifications to show notifications

and failing win test:

not ok 61 app module getGPUInfo() API succeeds with complete GPUInfo
      at getGPUInfo (C:\projects\src\electron\spec\api-app-spec.js:969:31)
      at processTicksAndRejections (internal/process/task_queues.js:86:5)
      at async Context.<anonymous> (C:\projects\src\electron\spec\api-app-spec.js:991:28)

are unrelated, and so i'm going to go ahead and merge this!

@codebytere codebytere merged commit a0872b2 into electron:5-0-x Jun 8, 2019
@release-clerk
Copy link

release-clerk bot commented Jun 8, 2019

Release Notes Persisted

Spellcheck providers are now (again) called with contractions and their parts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@nitsakh nitsakh Awaiting requested review from nitsakh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@code-elf @codebytere