Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ValueSerializer: Report if buffer expansion fails during WriteHostObject #18562

Merged
merged 4 commits into from Jun 4, 2019
Merged

fix: ValueSerializer: Report if buffer expansion fails during WriteHostObject #18562

merged 4 commits into from Jun 4, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jun 1, 2019 •
edited

Description of Change

Backport fix for https://bugs.chromium.org/p/chromium/issues/detail?id=914731
https://chromium.googlesource.com/v8/v8.git/+/8494c583ca1daf1208d272db038c1cee727548a8

ValueSerializer: Report if buffer expansion fails during WriteHostObject.

Also fail early if we detect that we've previously run out of memory and thus
corrupted the buffer.

Add a unit test for this kind of case.

/cc @electron/wg-security

Checklist

Release Notes

Notes: Backported fix for https://bugs.chromium.org/p/chromium/issues/detail?id=914731.

@miniak miniak added the 4-2-x label Jun 1, 2019
@miniak miniak requested a review from a team June 1, 2019 20:58
@miniak miniak self-assigned this Jun 1, 2019
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 1, 2019
@miniak miniak changed the title fix: ValueSerializer: Report if buffer expansion fails during WriteHostObject fix: Issue 914731: Security: The serialized data is corrupted because the return value is always true. Jun 1, 2019
@miniak miniak changed the title fix: Issue 914731: Security: The serialized data is corrupted because the return value is always true. fix: ValueSerializer: Report if buffer expansion fails during WriteHostObject Jun 1, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 2, 2019
@miniak miniak added security 🔒 backport This is a backport PR labels Jun 3, 2019
@miniak
Copy link
Contributor Author

miniak commented Jun 4, 2019

@codebytere ready to merge

@codebytere codebytere merged commit ee6c91d into 4-2-x Jun 4, 2019
@release-clerk
Copy link

release-clerk bot commented Jun 4, 2019

Release Notes Persisted

Backported fix for https://bugs.chromium.org/p/chromium/issues/detail?id=914731.

@codebytere codebytere deleted the miniak/backport-914731-4-2-x branch June 4, 2019 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere codebytere approved these changes

Assignees

@miniak miniak

Labels
4-2-x backport This is a backport PR security 🔒
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miniak @zcbenz @codebytere