Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Check array element length in ValueDeserializer #18565

Merged
merged 5 commits into from Jun 6, 2019
Merged

fix: Check array element length in ValueDeserializer #18565

merged 5 commits into from Jun 6, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jun 1, 2019

Description of Change

Backport fix for https://bugs.chromium.org/p/chromium/issues/detail?id=905940

https://chromium.googlesource.com/v8/v8.git/+/206b8e0851093e61cf22dc2af3f103df9f2de9b3

Check array element length in ValueDeserializer

https://chromium.googlesource.com/v8/v8.git/+/2028d1d8b1d2ce10aa27e7c73ea6dc398a0d7178

Add test case for ValueDeserializer

https://chromium.googlesource.com/v8/v8.git/+/cccaa27eca0d8fd3192b7f676b785cb8769b5b2d

Gracefully fail in ValueDeserializer

/cc @electron/wg-security

Checklist

Release Notes

Notes: Backported fix for https://bugs.chromium.org/p/chromium/issues/detail?id=905940.

@miniak miniak added the 4-2-x label Jun 1, 2019
@miniak miniak requested a review from a team June 1, 2019 21:42
@miniak miniak self-assigned this Jun 1, 2019
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 1, 2019
@miniak miniak force-pushed the miniak/backport-905940-4-2-x branch from 59e02b2 to f8a95fe Compare June 1, 2019 21:58
@miniak miniak changed the title fix: Issue 905940: OOB Write in ValueDeserializer::ReadDenseJSArray fix: Check array element length in ValueDeserializer Jun 1, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 2, 2019
@miniak miniak added security 🔒 backport This is a backport PR labels Jun 3, 2019
@miniak
Copy link
Contributor Author

miniak commented Jun 6, 2019

@codebytere ready to merge

@zcbenz zcbenz merged commit c9b9a0c into 4-2-x Jun 6, 2019
@release-clerk
Copy link

release-clerk bot commented Jun 6, 2019

Release Notes Persisted

Backported fix for https://bugs.chromium.org/p/chromium/issues/detail?id=905940.

@zcbenz zcbenz deleted the miniak/backport-905940-4-2-x branch June 6, 2019 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@zcbenz zcbenz zcbenz approved these changes

Assignees

@miniak miniak

Labels
4-2-x backport This is a backport PR security 🔒
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miniak @nornagon @zcbenz