Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [turbofan] Restrict redundancy elimination from widening types #18569

Merged
merged 2 commits into from Jun 4, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jun 1, 2019

Description of Change

Backport fix for https://bugs.chromium.org/p/chromium/issues/detail?id=919340
https://chromium.googlesource.com/v8/v8.git/+/5a9fa8f304c2a627af21d7b35488be8f4bf24b47

[turbofan] Restrict redundancy elimination from widening types

This CL prevents redundancy elimination from widening types, which
can cause problems if the input of a DeadValue (which has type None)
is replaced by an equivalent node that does not have type None. This
can happen because load elimination does not re-type nodes, for
example.

/cc @electron/wg-security

Checklist

Release Notes

Notes: Backported fix for https://bugs.chromium.org/p/chromium/issues/detail?id=919340.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 1, 2019
@miniak miniak requested a review from a team June 1, 2019 22:49
@miniak miniak self-assigned this Jun 1, 2019
@miniak miniak added the 4-2-x label Jun 1, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 2, 2019
@miniak miniak added security 🔒 backport This is a backport PR labels Jun 3, 2019
@zcbenz zcbenz merged commit 3d3d979 into 4-2-x Jun 4, 2019
@release-clerk
Copy link

release-clerk bot commented Jun 4, 2019

Release Notes Persisted

Backported fix for https://bugs.chromium.org/p/chromium/issues/detail?id=919340.

@zcbenz zcbenz deleted the miniak/backport-919340-4-2-x branch June 4, 2019 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants