fix: lost window.opener after cross-origin navigation #18614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fact that, now, we always have an opener for opened windows diables note integration in opened windows, except if `nodeIntegrationInSubFrames` is enabled.
…s-origin navigation" This reverts commit 0a7537f.
5 tasks
alexstrat
commented
Jun 4, 2019
| @@ -1,364 +0,0 @@ | |||
| From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 | |||
There was a problem hiding this comment.
This patch is not used anymore.
alexstrat
changed the title
alexstrat
commented
Jun 4, 2019
| @@ -306,7 +307,6 @@ describe('BrowserWindow module', () => { | |||
| }) | |||
|
|
|||
| it('should return a promise that resolves even if pushState occurs during navigation', async () => { | |||
| const data = Buffer.alloc(2 * 1024 * 1024).toString('base64') | |||
deepak1556
approved these changes
Jun 11, 2019
zcbenz
approved these changes
Jun 11, 2019
codebytere
approved these changes
Jun 12, 2019
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Backport of #18173
Checklist
npm testpassesRelease Notes
Notes: Fixed
window.openernull after cross-origin navigation