Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't export private V8 symbols that can cause native node modules to crash #18621

Merged
merged 1 commit into from Jun 4, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jun 4, 2019

Description of Change

Backport of #18281

Checklist

Release Notes

Notes: Removed incorrectly published internal V8 symbols and CRT methods from node.lib, causing heap corruptions with node modules using the dynamic CRT on Windows.

@ckerr ckerr merged commit 49dc154 into 4-2-x Jun 4, 2019
@release-clerk
Copy link

release-clerk bot commented Jun 4, 2019

Release Notes Persisted

Removed incorrectly published internal V8 symbols and CRT methods from node.lib, causing heap corruptions with node modules using the dynamic CRT on Windows.

@ckerr ckerr deleted the miniak/backport-v8-private-symbols-4-2-x branch June 4, 2019 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4-2-x backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants