Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use isEqual instead of pointer equality to convert NSAppearance #18691

Merged
merged 1 commit into from Jun 10, 2019
Merged

fix: use isEqual instead of pointer equality to convert NSAppearance #18691

merged 1 commit into from Jun 10, 2019

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jun 7, 2019

Backport of #18665

See that PR for details.

Notes: Fixed issue where getEffectiveApperance and getAppLevelAppearance would return unknown instead of the correct value sometimes

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 7, 2019
@trop trop bot mentioned this pull request Jun 7, 2019
Merged
@trop trop bot added 4-2-x backport This is a backport PR labels Jun 7, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 7, 2019
@codebytere
Copy link
Member

macOS error is flake only present on non-mas builds, so i'm going to go ahead and merge this.

@codebytere codebytere merged commit 972d45d into 4-2-x Jun 10, 2019
@release-clerk
Copy link

release-clerk bot commented Jun 10, 2019

Release Notes Persisted

Fixed issue where getEffectiveApperance and getAppLevelAppearance would return unknown instead of the correct value sometimes

@codebytere codebytere deleted the trop/4-2-x-bp-fix-use-isequal-instead-of-pointer-equality-to-convert-nsappearance-1559926549048 branch June 10, 2019 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniak miniak miniak approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
4-2-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @miniak @MarshallOfSound