Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: provide the frame URL with permission requests and checks #18773

Merged
merged 1 commit into from Jul 11, 2019
Merged

feat: provide the frame URL with permission requests and checks #18773

merged 1 commit into from Jul 11, 2019

Conversation

MarshallOfSound
Copy link
Member

Backport of #18757

See that PR for details

Notes: Added requestingUrl and isMainFrame properties to the permission request and permission check handlers details objects so that apps can check the origin of the requesting frame rather than the root frame.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 13, 2019
@trop trop bot mentioned this pull request Jun 13, 2019
Merged
@MarshallOfSound MarshallOfSound added fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases backport This is a backport PR and removed target/3-1-x labels Jun 13, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 14, 2019
zcbenz
zcbenz previously requested changes Jun 15, 2019
View reviewed changes
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compilation fails.

@MarshallOfSound
feat: provide the frame URL with permission requests and checks (#18757)
a897301 
* feat: provide the frame URL with permission requests and checks

Also provides a handy isMainFrame property to determine if it is an
iframe making the request

* chore: refactor to use base::Value

* chore: use Set<Type>Key over SetPath
@zcbenz zcbenz merged commit 8e68e6e into 5-0-x Jul 11, 2019
@release-clerk
Copy link

release-clerk bot commented Jul 11, 2019

Release Notes Persisted

Added requestingUrl and isMainFrame properties to the permission request and permission check handlers details objects so that apps can check the origin of the requesting frame rather than the root frame.

@zcbenz zcbenz deleted the feat/permission-frame-url-5 branch July 11, 2019 09:00
@trop trop bot mentioned this pull request Jul 11, 2019
Merged
@trop
Copy link
Contributor

trop bot commented Jul 11, 2019

I have automatically backported this PR to "4-2-x", please check out #19204

@codebytere codebytere mentioned this pull request Jul 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
backport This is a backport PR fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MarshallOfSound @zcbenz @codebytere