Remove iframe node from <webview> will cause webview crash.

[cloudsere]

Preflight Checklist

• I have read the Contributing Guidelines for this project.
• I agree to follow the Code of Conduct that this project adheres to.
• I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

• Electron Version:
  • v5.0.2
• Operating System:
  • macOS 10.13.6
• Last Known Working Electron version:
  • Haven't tried on other electron versions.

Expected Behavior

I have an app which runs in electron <webview>. I need to render multiple iframes inside this <webview> and dynamic add or remove them.

Actual Behavior

When I remove one <iframe> from the dom tree, the whole <webview> crashes. I didn't use JS to remove iframe node, instead, I just delete one <iframe> from the dom inspector, and the <webview> crashes.

To Reproduce

This is an example : https://github.com/cloudsere/electron-quick-start. You can run commands below to reproduce.

$ git clone https://github.com/cloudsere/electron-quick-start
$ npm install
$ npm start

[alexstrat]

Here is a gist to be used in electron-fiddle to reproduce the issue:

Note that it does not seem that the webview itself has crashed (I can access DOM via DevTools) but rather that the repainting is getting blocked.

Tested with other versions:

• 4.2.4: not reproduced
• 5.0.5: reproduced
• 5.0.4: reproduced
• 6.0.0-beta.1: reproduced
• 6.0.0-beta.2: not reproduced
• 6.0.0-beta.9: not reproduced

[alexstrat]

Relates, or even duplicates #17890

[alexstrat]

The fact that the bug is not reproduced with 6.0.0-beta.2 whereas it was present beta.1 is a sign that there is a fix hiding in the diff Chrome 76.0.3774.1 => 76.0.3783.1.

This one is a good candidate: https://chromium.googlesource.com/chromium/src/+/7464a6b4e3cf91dd1eb96d922736f0815b94ed9c%5E%21/#F3

[cloudsere]

The fact that the bug is not reproduced with 6.0.0-beta.2 whereas it was present beta.1 is a sign that there is a fix hiding in the diff Chrome 76.0.3774.1 => 76.0.3783.1.

This one is a good candidate: https://chromium.googlesource.com/chromium/src/+/7464a6b4e3cf91dd1eb96d922736f0815b94ed9c%5E%21/#F3

Thank you , this fix works!

[sofianguy]

fixed #18976