Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set nativeWindowOpen when sandboxed #18798

Merged
merged 1 commit into from Jun 20, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jun 14, 2019

Description of Change

Backport of: #18273

Checklist

Release Notes

Notes:

  • Fixed issues with popups created from sandboxed <webview>:
  • Clicking link with target="_blank" not emitting 'new-window' event.
  • window.open() not returning null when allowpopups is not set.

@miniak miniak added backport This is a backport PR 5-0-x labels Jun 14, 2019
@miniak miniak requested a review from a team June 14, 2019 14:08
@miniak miniak self-assigned this Jun 14, 2019
@trop trop bot mentioned this pull request Jun 14, 2019
5 tasks
@miniak miniak changed the title fix: set nativeWindowOpen when sandboxed (#18273) fix: set nativeWindowOpen when sandboxed Jun 14, 2019
@zcbenz
Copy link
Member

zcbenz commented Jun 15, 2019

@MarshallOfSound I saw you explained concerns about backporting it to 4/5 in #18273, are you OK with this backport?

@MarshallOfSound
Copy link
Member

@zcbenz My concerns still apply and I would have preferred this went through @electron/wg-releases to get the backport approved given my voiced concern in the original PR. My approval on the original PR was actually directly conditional on it not being an approval of the backport.

I'm like -0 on this, if other folks want to merge it go ahead but I stand by the fact that it is a decently large change in behavior to float in a patch release.

Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending Releases WG approval

@codebytere codebytere dismissed jkleinsc’s stale review June 20, 2019 15:25

The Releases WG has chosen to approve this backport per latest meeting

@codebytere codebytere merged commit 4318ad8 into 5-0-x Jun 20, 2019
@release-clerk
Copy link

release-clerk bot commented Jun 20, 2019

Release Notes Persisted

  • Fixed issues with popups created from sandboxed <webview>:
  • Clicking link with target="_blank" not emitting 'new-window' event.
  • window.open() not returning null when allowpopups is not set.

@codebytere codebytere deleted the miniak/miniak/fix-new-window-in-sandbox-5-0-x branch June 20, 2019 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5-0-x backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants