Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: callback values for printing cancellation and success #18804

Merged
merged 1 commit into from Jun 15, 2019

Conversation

codebytere
Copy link
Member

Backport of #17400.

See that PR for more details.

Notes: Fixed webContents.print() callback not returning boolean correctly in all cases.

@codebytere codebytere added backport This is a backport PR 5-0-x labels Jun 14, 2019
@zcbenz zcbenz merged commit 226dd75 into 5-0-x Jun 15, 2019
@release-clerk
Copy link

release-clerk bot commented Jun 15, 2019

Release Notes Persisted

Fixed webContents.print() callback not returning boolean correctly in all cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5-0-x backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants