Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Uncaught TypeError: Cannot set property 'innerText' of null in default-app #18818

Merged
merged 1 commit into from Jun 17, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jun 15, 2019

Description of Change

100% repro when default-app is used to open a website.

The problem is that the code assumes these elements to be present in the DOM, which is not the case if any other page is loaded.

    <ul class="versions code">
      <li class="electron-version"></li>
      <li class="chrome-version"></li>
      <li class="node-version"></li>
      <li class="v8-version"></li>
    </ul>

Example electron https://www.example.com/
Screen Shot 2019-06-15 at 3 01 50 PM

Checklist

Release Notes

Notes: Fixed Uncaught TypeError: Cannot set property 'innerText' of null in default-app when opening a website.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 15, 2019
@miniak miniak self-assigned this Jun 15, 2019
@miniak miniak added the 4-2-x label Jun 15, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 16, 2019
@codebytere codebytere merged commit 690e94a into 4-2-x Jun 17, 2019
@release-clerk
Copy link

release-clerk bot commented Jun 17, 2019

Release Notes Persisted

Fixed Uncaught TypeError: Cannot set property 'innerText' of null in default-app when opening a website.

@codebytere codebytere deleted the miniak/fix-default-app-4-2-x branch June 17, 2019 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants