fix: Uncaught TypeError: Cannot set property 'innerText' of null in default-app #18818
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
100% repro when default-app is used to open a website.
The problem is that the code assumes these elements to be present in the DOM, which is not the case if any other page is loaded.
Example
electron https://www.example.com/
Checklist
npm test
passesRelease Notes
Notes: Fixed
Uncaught TypeError: Cannot set property 'innerText' of null
in default-app when opening a website.