Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: session.{clearCache,getCacheSize} nws13n #18898

Merged
merged 1 commit into from Jun 21, 2019
Merged

refactor: session.{clearCache,getCacheSize} nws13n #18898

merged 1 commit into from Jun 21, 2019
+13 −1

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Jun 20, 2019 •
edited

Description of Change

Fixes #17189.

Backport of #17969. We haven't promisified this in 5 so this is a callbackified version of that PR.

cc @nornagon

Checklist

Release Notes

Notes: Fix an issue where session.getCacheSize would never call its callback.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 20, 2019
@codebytere codebytere requested a review from nornagon June 20, 2019 06:45
@codebytere codebytere changed the title [wip] refactor: session.{clearCache,getCacheSize} nws13n refactor: session.{clearCache,getCacheSize} nws13n Jun 20, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 21, 2019
@codebytere codebytere added 5-0-x backport This is a backport PR labels Jun 21, 2019
@codebytere
Copy link
Member Author

Failing spec on linux is:

webContents module create() does not crash on exit - does not crash on exit

which is not affected by the codepaths changed in this PR and which i would therefore say is a flake.

@codebytere codebytere merged commit 385e548 into 5-0-x Jun 21, 2019
@release-clerk
Copy link

release-clerk bot commented Jun 21, 2019

Release Notes Persisted

Fix an issue where session.getCacheSize would never call its callback.

@codebytere codebytere deleted the bp-nw-cache-size-5 branch June 21, 2019 16:47
@trop trop bot mentioned this pull request Jun 21, 2019
Merged
@trop
Copy link
Contributor

trop bot commented Jun 21, 2019

I have automatically backported this PR to "4-2-x", please check out #18921

@codebytere codebytere mentioned this pull request Jun 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

Assignees
No one assigned
Labels
5-0-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @nornagon