Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: session.{clearCache,getCacheSize} nws13n #18921

Merged
merged 1 commit into from Jun 21, 2019
Merged

refactor: session.{clearCache,getCacheSize} nws13n #18921

merged 1 commit into from Jun 21, 2019

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jun 21, 2019

Backport of #18898

See that PR for details.

Notes: Fix an issue where session.getCacheSize would never call its callback.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 21, 2019
@trop trop bot mentioned this pull request Jun 21, 2019
Merged
4 tasks
@trop trop bot added 4-2-x backport This is a backport PR labels Jun 21, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 21, 2019
@codebytere codebytere merged commit 65c53cc into 4-2-x Jun 21, 2019
@release-clerk
Copy link

release-clerk bot commented Jun 21, 2019

Release Notes Persisted

Fix an issue where session.getCacheSize would never call its callback.

@codebytere codebytere deleted the trop/4-2-x-bp-refactor-session-clearcache-getcachesize-nws13n-1561135674550 branch June 21, 2019 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
4-2-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@codebytere