Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: override the timers module impls to activate the uv loop #18968

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jun 25, 2019

Backport of #18965

See that PR for details.

Notes: Fixed issue where require('timers').setTimeout would sometimes never fire in the renderer process

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 25, 2019
@trop trop bot added 4-2-x backport This is a backport PR labels Jun 25, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 25, 2019
@codebytere codebytere merged commit 8acf577 into 4-2-x Jun 25, 2019
@release-clerk
Copy link

release-clerk bot commented Jun 25, 2019

Release Notes Persisted

Fixed issue where require('timers').setTimeout would sometimes never fire in the renderer process

@codebytere codebytere deleted the trop/4-2-x-bp-fix-override-the-timers-module-impls-to-activate-the-uv-loop-1561428889161 branch June 25, 2019 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4-2-x backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants