Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make tray not block main process #19036

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jun 28, 2019

Backport of #18969

See that PR for details.

Notes: Fixed an issue where the Tray icon context menu on macOS blocked the main process while open.

* fix: make tray not block main process

* make AtomMenuModel refcounted
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 28, 2019
@trop trop bot added 5-0-x backport This is a backport PR labels Jun 28, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 28, 2019
@codebytere codebytere merged commit 7865fa3 into 5-0-x Jun 28, 2019
@release-clerk
Copy link

release-clerk bot commented Jun 28, 2019

Release Notes Persisted

Fixed an issue where the Tray icon context menu on macOS blocked the main process while open.

@codebytere codebytere deleted the trop/5-0-x-bp-fix-make-tray-not-block-main-process-1561749068251 branch June 28, 2019 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5-0-x backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant