fix: disable animation for win.setSimpleFullScreen on 4.x #19143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
approved these changes
Jul 8, 2019
codebytere
approved these changes
Jul 9, 2019
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR fixes the bug described in microsoft/vscode#75054.
There is a bug with Chromium that, after setting window style, calling setFrame with animation immediately would block window rendering for a few seconds.
This Chromium bug is fixed in later versions, but it is hard to find out how to backport the fix or how to work around it, disabling the animation is the easist fix and most users would not even notice it.
Checklist
npm testpassesRelease Notes
Notes: Fix toggling simple fullscreen being very slow.