fix: Windows OnSecreenKeyboard for various mouse events (4-2-x) #19144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
changed the title
zcbenz
approved these changes
Jul 9, 2019
codebytere
approved these changes
Jul 9, 2019
There was a problem hiding this comment.
approving on behalf of @electron/wg-releases but i'd like another review from @electron/wg-upgrades before merging
cc @nornagon
nornagon
approved these changes
Jul 9, 2019
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Backports the following CLs:
https://chromium-review.googlesource.com/c/chromium/src/+/1194406/
https://chromium-review.googlesource.com/c/chromium/src/+/1220560/
https://chromium-review.googlesource.com/c/chromium/src/+/1140199/ (this one was backported to safely apply the other two CLs)
Crbug: https://bugs.chromium.org/p/chromium/issues/detail?id=871756
This is fixed for 70 and higher.
Fixes microsoft/vscode#76560
Checklist
npm testpassesRelease Notes
Notes: fix windows virtual keyboard appearing for all mouse events