Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron 5 for Linux / Windows ships unused files in resources/inspector #19174

Closed
3 tasks done
miniak opened this issue Jul 9, 2019 · 2 comments
Closed
3 tasks done

Comments

@miniak
Copy link
Contributor

miniak commented Jul 9, 2019

Preflight Checklist

  • I have read the Contributing Guidelines for this project.
  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

  • Electron Version:
    • Electron 5 is affected
  • Operating System:
    • Windows / Linux
  • Last Known Working Electron version:
    • Electron 4 and Electron 6 are not affected

Screenshots

Screen Shot 2019-07-09 at 6 25 50 PM

Screen Shot 2019-07-09 at 6 26 21 PM

Additional Information

resources/inspector/.htaccess
resources/inspector/Images/accelerometer-back.svg
resources/inspector/Images/accelerometer-bottom.png
resources/inspector/Images/accelerometer-front.svg
resources/inspector/Images/accelerometer-left.png
resources/inspector/Images/accelerometer-right.png
resources/inspector/Images/accelerometer-top.png
resources/inspector/Images/audits_logo.svg
resources/inspector/Images/breakpoint.png
resources/inspector/Images/breakpointConditional.png
resources/inspector/Images/breakpointConditional_2x.png
resources/inspector/Images/breakpoint_2x.png
resources/inspector/Images/checker.png
resources/inspector/Images/chromeDisabledSelect.png
resources/inspector/Images/chromeDisabledSelect_2x.png
resources/inspector/Images/chromeLeft.png
resources/inspector/Images/chromeMiddle.png
resources/inspector/Images/chromeRight.png
resources/inspector/Images/chromeSelect.png
resources/inspector/Images/chromeSelect_2x.png
resources/inspector/Images/errorWave.png
resources/inspector/Images/errorWave_2x.png
resources/inspector/Images/ic_info_black_18dp.svg
resources/inspector/Images/ic_warning_black_18dp.svg
resources/inspector/Images/largeIcons.png
resources/inspector/Images/largeIcons_2x.png
resources/inspector/Images/mediumIcons.png
resources/inspector/Images/mediumIcons_2x.png
resources/inspector/Images/navigationControls.png
resources/inspector/Images/navigationControls_2x.png
resources/inspector/Images/nodeIcon.png
resources/inspector/Images/popoverArrows.png
resources/inspector/Images/profileGroupIcon.png
resources/inspector/Images/profileIcon.png
resources/inspector/Images/profileSmallIcon.png
resources/inspector/Images/radioDot.png
resources/inspector/Images/resizeDiagonal.png
resources/inspector/Images/resizeDiagonal_2x.png
resources/inspector/Images/resizeHorizontal.png
resources/inspector/Images/resizeHorizontal_2x.png
resources/inspector/Images/resizeVertical.png
resources/inspector/Images/resizeVertical_2x.png
resources/inspector/Images/resourceCSSIcon.png
resources/inspector/Images/resourceDocumentIcon.png
resources/inspector/Images/resourceDocumentIconSmall.png
resources/inspector/Images/resourceJSIcon.png
resources/inspector/Images/resourcePlainIcon.png
resources/inspector/Images/resourcePlainIconSmall.png
resources/inspector/Images/resourcesTimeGraphIcon.png
resources/inspector/Images/searchNext.png
resources/inspector/Images/searchPrev.png
resources/inspector/Images/securityIcons.png
resources/inspector/Images/securityIcons_2x.png
resources/inspector/Images/smallIcons.png
resources/inspector/Images/smallIcons_2x.png
resources/inspector/Images/speech.png
resources/inspector/Images/toolbarResizerVertical.png
resources/inspector/Images/touchCursor.png
resources/inspector/Images/touchCursor_2x.png
resources/inspector/Images/treeoutlineTriangles.png
resources/inspector/Images/treeoutlineTriangles_2x.png
resources/inspector/Images/whatsnew.png
resources/inspector/InspectorBackendCommands.js
resources/inspector/SupportedCSSProperties.js
resources/inspector/Tests.js
resources/inspector/accessibility/ARIAProperties.js
resources/inspector/accessibility/accessibility_module.js
resources/inspector/accessibility_test_runner/accessibility_test_runner_module.js
resources/inspector/animation/animation_module.js
resources/inspector/application_test_runner/application_test_runner_module.js
resources/inspector/audits2/audits2_module.js
resources/inspector/audits2_test_runner/audits2_test_runner_module.js
resources/inspector/audits2_worker.js
resources/inspector/audits2_worker/audits2_worker_module.js
resources/inspector/bindings_test_runner/bindings_test_runner_module.js
resources/inspector/browser_debugger/browser_debugger_module.js
resources/inspector/changes/changes_module.js
resources/inspector/cm/cm_module.js
resources/inspector/cm_modes/cm_modes_module.js
resources/inspector/color_picker/color_picker_module.js
resources/inspector/console/console_module.js
resources/inspector/console_test_runner/console_test_runner_module.js
resources/inspector/cookie_table/cookie_table_module.js
resources/inspector/coverage/coverage_module.js
resources/inspector/coverage_test_runner/coverage_test_runner_module.js
resources/inspector/cpu_profiler_test_runner/cpu_profiler_test_runner_module.js
resources/inspector/data_grid/data_grid_module.js
resources/inspector/data_grid_test_runner/data_grid_test_runner_module.js
resources/inspector/device_mode_test_runner/device_mode_test_runner_module.js
resources/inspector/devices/devices_module.js
resources/inspector/devtools_app.html
resources/inspector/devtools_app.js
resources/inspector/devtools_compatibility.js
resources/inspector/devtools_extension_api.js
resources/inspector/diff/diff_module.js
resources/inspector/elements/elements_module.js
resources/inspector/elements_test_runner/elements_test_runner_module.js
resources/inspector/emulated_devices/Nexus5X-landscape.svg
resources/inspector/emulated_devices/Nexus5X-portrait.svg
resources/inspector/emulated_devices/Nexus6P-landscape.svg
resources/inspector/emulated_devices/Nexus6P-portrait.svg
resources/inspector/emulated_devices/emulated_devices_module.js
resources/inspector/emulated_devices/google-nexus-5-horizontal-default-1x.png
resources/inspector/emulated_devices/google-nexus-5-horizontal-default-2x.png
resources/inspector/emulated_devices/google-nexus-5-horizontal-keyboard-1x.png
resources/inspector/emulated_devices/google-nexus-5-horizontal-keyboard-2x.png
resources/inspector/emulated_devices/google-nexus-5-horizontal-navigation-1x.png
resources/inspector/emulated_devices/google-nexus-5-horizontal-navigation-2x.png
resources/inspector/emulated_devices/google-nexus-5-vertical-default-1x.png
resources/inspector/emulated_devices/google-nexus-5-vertical-default-2x.png
resources/inspector/emulated_devices/google-nexus-5-vertical-keyboard-1x.png
resources/inspector/emulated_devices/google-nexus-5-vertical-keyboard-2x.png
resources/inspector/emulated_devices/google-nexus-5-vertical-navigation-1x.png
resources/inspector/emulated_devices/google-nexus-5-vertical-navigation-2x.png
resources/inspector/emulated_devices/google-nexus-5x-horizontal-default-1x.png
resources/inspector/emulated_devices/google-nexus-5x-horizontal-default-2x.png
resources/inspector/emulated_devices/google-nexus-5x-horizontal-keyboard-1x.png
resources/inspector/emulated_devices/google-nexus-5x-horizontal-keyboard-2x.png
resources/inspector/emulated_devices/google-nexus-5x-horizontal-navigation-1x.png
resources/inspector/emulated_devices/google-nexus-5x-horizontal-navigation-2x.png
resources/inspector/emulated_devices/google-nexus-5x-vertical-default-1x.png
resources/inspector/emulated_devices/google-nexus-5x-vertical-default-2x.png
resources/inspector/emulated_devices/google-nexus-5x-vertical-keyboard-1x.png
resources/inspector/emulated_devices/google-nexus-5x-vertical-keyboard-2x.png
resources/inspector/emulated_devices/google-nexus-5x-vertical-navigation-1x.png
resources/inspector/emulated_devices/google-nexus-5x-vertical-navigation-2x.png
resources/inspector/emulated_devices/iPad-landscape.svg
resources/inspector/emulated_devices/iPad-portrait.svg
resources/inspector/emulated_devices/iPhone5-landscape.svg
resources/inspector/emulated_devices/iPhone5-portrait.svg
resources/inspector/emulated_devices/iPhone6-landscape.svg
resources/inspector/emulated_devices/iPhone6-portrait.svg
resources/inspector/emulated_devices/iPhone6Plus-landscape.svg
resources/inspector/emulated_devices/iPhone6Plus-portrait.svg
resources/inspector/event_listeners/event_listeners_module.js
resources/inspector/extensions_test_runner/extensions_test_runner_module.js
resources/inspector/formatter/formatter_module.js
resources/inspector/formatter_worker.js
resources/inspector/har_importer/har_importer_module.js
resources/inspector/heap_profiler_test_runner/heap_profiler_test_runner_module.js
resources/inspector/heap_snapshot_model/heap_snapshot_model_module.js
resources/inspector/heap_snapshot_worker.js
resources/inspector/heap_snapshot_worker/heap_snapshot_worker_module.js
resources/inspector/help/help_module.js
resources/inspector/inline_editor/inline_editor_module.js
resources/inspector/inspector.html
resources/inspector/inspector.js
resources/inspector/integration_test_runner.html
resources/inspector/integration_test_runner.js
resources/inspector/javascript_metadata/javascript_metadata_module.js
resources/inspector/js_app.html
resources/inspector/js_app.js
resources/inspector/js_profiler/js_profiler_module.js
resources/inspector/layer_viewer/layer_viewer_module.js
resources/inspector/layers/layers_module.js
resources/inspector/layers_test_runner/layers_test_runner_module.js
resources/inspector/network/network_module.js
resources/inspector/network_test_runner/network_test_runner_module.js
resources/inspector/node_app.html
resources/inspector/node_app.js
resources/inspector/node_debugger/node_debugger_module.js
resources/inspector/object_ui/object_ui_module.js
resources/inspector/perf_ui/perf_ui_module.js
resources/inspector/performance_monitor/performance_monitor_module.js
resources/inspector/performance_test_runner/performance_test_runner_module.js
resources/inspector/product_registry_impl/product_registry_impl_module.js
resources/inspector/profiler/profiler_module.js
resources/inspector/protocol_monitor/protocol_monitor_module.js
resources/inspector/quick_open/quick_open_module.js
resources/inspector/resources/resources_module.js
resources/inspector/sdk_test_runner/sdk_test_runner_module.js
resources/inspector/search/search_module.js
resources/inspector/security/security_module.js
resources/inspector/security_test_runner/security_test_runner_module.js
resources/inspector/settings/settings_module.js
resources/inspector/shell.js
resources/inspector/snippets/snippets_module.js
resources/inspector/source_frame/source_frame_module.js
resources/inspector/sources/sources_module.js
resources/inspector/sources_test_runner/sources_test_runner_module.js
resources/inspector/text_editor/text_editor_module.js
resources/inspector/timeline/timeline_module.js
resources/inspector/timeline_model/timeline_model_module.js
resources/inspector/toolbox.html
resources/inspector/toolbox.js
resources/inspector/worker_app.html
resources/inspector/worker_app.js
resources/inspector/workspace_diff/workspace_diff_module.js
@malept
Copy link
Member

malept commented Jul 9, 2019

Looks like a duplicate of #19075 ?

@miniak
Copy link
Contributor Author

miniak commented Jul 9, 2019

@malept yes, closing this one

@miniak miniak closed this as completed Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants