fix: backport patch for leaking HTML5 video elements

[MarshallOfSound]

Backports https://chromium-review.googlesource.com/c/chromium/src/+/1677053 to 4-2-x to fix a rather noticeable memory leak when removing HTML5 video elements from the DOM

Notes: Fixed memory leak when removing HTML5 video elements from the DOM with Javascript

[codebytere]

@MarshallOfSound it looks like some things got altered orthogonal to this patch:

see these changes

[MarshallOfSound]

@codebytere Those changes are due to the different versions of git folks have on their machines (namely me and @nornagon have different git versions) we fixed this in the patch scripts in more recent branches (I think 6-0-x and above). The changes are ok 👍

[jkleinsc]

@MarshallOfSound while those additional changes may have no effect, they are confusing. Can't you just bring in the changes to .patches and the new mediacontrols_disconnect_observers_when_controls_are_hidden.patch file?

[MarshallOfSound]

I just ran git-export-patches. I'd rather avoid manually editing patch files by hand or picking and choosing.

[jkleinsc]

@MarshallOfSound I get that but couldn't you be selective on what files you commit?

[MarshallOfSound]

@jkleinsc those hunks generate the sha that my newly added patch is based off of. It might work, but it might not. Id rather just take the output of git-export-patches.

[MarshallOfSound]

test failures look video related, I'll take a look

[MarshallOfSound]

@jkleinsc @codebytere Tests are fixed, should be All Clear now. Needed to handle a nullptr case that the original CL did not as Chromium has removed legacy media inputs in C75, we still have them in C69 👍

[codebytere]

Approving given added context above!

[deepak1556]

Needed to handle a nullptr case that the original CL did not as Chromium has removed legacy media inputs in C75, we still have them in C69

Can you share the CL that changed this ? I am concerned that volume_slider_ is expected to be non-null and while it doesn't. There are other locations in the code where they null protect against volume_slider_.

Did you try running with --enable-features=UseModernMediaControls to check if its the legacy controls thats causing this difference ?

[deepak1556]

LGTM, I don't have context on the media code changes, so can't assert for the nullptr check introduced additionally. Besides nullptr check is not gonna cause trouble here anyways.

[release-clerk]

Release Notes Persisted

Fixed memory leak when removing HTML5 video elements from the DOM with Javascript

[peteringram0]

@MarshallOfSound Does this also fix the following bug: #18019 ? Thanks