Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Windows on Arm's compiler again #19383

Merged
merged 1 commit into from Aug 15, 2019

Conversation

richard-townsend-arm
Copy link
Contributor

@richard-townsend-arm richard-townsend-arm commented Jul 23, 2019

Description of Change

This change, specific to Windows on Arm, updates the compiler to an even later version which supports emitting CodeView debug information. Whilst the previous compiler didn't have any known code-gen issues, Visual Studio could not display detailed information (like the values of variables) whilst debugging. This version of the compiler also has no known code-gen issues, but makes for a nicer debugging experience.

We've successfully brought up Visual Studio Code's Electron 6 branch with this compiler and have been testing it internally, so we're confident that there aren't any remaining issues. This PR is only for the 6-0-x branch because master has already updated to a version of Chromium which includes this compiler.

CC: @jkleinsc

Checklist

Release Notes

Notes: no-notes

This WoA-specific change updates the compiler to one that produces
CodeView debug symbols, which means that Visual Studio can display the
values of variables whilst debugging.
@richard-townsend-arm richard-townsend-arm requested a review from a team as a code owner July 23, 2019 13:58
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 23, 2019
@richard-townsend-arm
Copy link
Contributor Author

Mac CI failure seems spurious (this platform will not be affected by this change unless ELECTRON_BUILDING_WOA is accidentally set in the environment).

not ok 108 autoUpdater behavior "before each" hook for "should have a valid code signing identity"
  Error: No valid signing identity available to run autoUpdater specs
      at Context.<anonymous> (electron/spec-main/api-autoupdater-darwin-spec.ts:26:15)
      at processImmediate (internal/timers.js:439:21)

Lint failure seems spurious: log mentions documentation (which wasn't updated by this patch).

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 24, 2019
@jkleinsc
Copy link
Contributor

jkleinsc commented Aug 15, 2019

Merging as CI failures unrelated to this PR.

@jkleinsc jkleinsc merged commit be68c06 into electron:6-0-x Aug 15, 2019
@release-clerk
Copy link

release-clerk bot commented Aug 15, 2019

Release Notes Persisted

no-notes

@sofianguy sofianguy added this to 6.0.3 in 6.1.x Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
6.1.x
6.0.3
Development

Successfully merging this pull request may close these issues.

None yet

2 participants