fix: crash on window.print() #19677
Merged
fix: crash on window.print() #19677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkleinsc
approved these changes
Aug 8, 2019
|
Release Notes Persisted
|
|
Checked v5 v6 and v7 after fix releases, because I need to specify the printer as device name, result only v7 works as intended with deviceName name specified |
|
Yes @misbeliever, i have not yet been able to backport this fix to v6/v5; it's a Chromium patch so it's a bit more complex unfortunately. I'll do my best to get to it soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #19601.
See that PR for more details.
Notes: Fixed a crash in
window.print().