Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: normalize behavior of win.setOpacity() for invalid number values across operating systems #19723

Merged
merged 6 commits into from Aug 15, 2019

Conversation

erickzhao
Copy link
Member

Backport of #19535.

See that PR for more details.

Notes: Normalized out-of-bound value behavior for the setOpacity() API in BrowserWindow.

Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erickzhao 6-0-x doesn't use expect in that file: those tests all need to be assert-based, which is why CI is all failing.

@ckerr ckerr merged commit dbf8872 into 6-0-x Aug 15, 2019
@release-clerk
Copy link

release-clerk bot commented Aug 15, 2019

Release Notes Persisted

Normalized out-of-bound value behavior for the setOpacity() API in BrowserWindow.

@ckerr ckerr deleted the bp/6-0-x/opacity branch August 15, 2019 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6-0-x backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants