Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: MessageBoxOptions.icon should allow type string #19798

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Aug 16, 2019

Backport of #19782

See that PR for details.

Notes: Allowed string as type on MessageBoxOptions.icon to support file paths as mentioned in NativeImage documentation

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 16, 2019
@trop trop bot added 6-0-x backport This is a backport PR labels Aug 16, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 16, 2019
@codebytere codebytere merged commit 33c8652 into 6-0-x Aug 16, 2019
@release-clerk
Copy link

release-clerk bot commented Aug 16, 2019

Release Notes Persisted

Allowed string as type on MessageBoxOptions.icon to support file paths as mentioned in NativeImage documentation

@codebytere codebytere deleted the trop/6-0-x-bp-docs-messageboxoptions-icon-should-allow-type-string-1565967981659 branch August 16, 2019 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6-0-x backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants