Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure child_process.fork() doesn't modify main process env #19845

Merged
merged 1 commit into from Aug 23, 2019
Merged

fix: ensure child_process.fork() doesn't modify main process env #19845

merged 1 commit into from Aug 23, 2019

Conversation

codebytere
Copy link
Member

Backport of #19742

See that PR for details.

Notes: Fixed an issue where a call to child_process.fork() would set ELECTRON_RUN_AS_NODE in the main process.

@codebytere codebytere added backport This is a backport PR 6-0-x labels Aug 20, 2019
@codebytere codebytere requested a review from a team as a code owner August 20, 2019 16:55
@trop trop bot mentioned this pull request Aug 20, 2019
Merged
4 tasks
@codebytere codebytere requested a review from a team August 20, 2019 18:08
@codebytere
Copy link
Member Author 

not ok 750 session module ses.protocol handles requests from partition
  Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (C:\projects\src\electron\spec\api-session-spec.js)
      at Test.Runnable._timeoutError (C:\projects\src\electron\spec\node_modules\mocha\lib\runnable.js:440:10)
      at C:\projects\src\electron\spec\node_modules\mocha\lib\runnable.js:251:24

is a known flake.

@zcbenz
Copy link
Member

zcbenz commented Aug 23, 2019 •
edited

This requires approval from @electron/wg-upgrades.

@MarshallOfSound MarshallOfSound merged commit 5e33a5e into 6-0-x Aug 23, 2019
@release-clerk
Copy link

release-clerk bot commented Aug 23, 2019

Release Notes Persisted

Fixed an issue where a call to child_process.fork() would set ELECTRON_RUN_AS_NODE in the main process.

@MarshallOfSound MarshallOfSound deleted the env-fresh-6 branch August 23, 2019 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@zcbenz zcbenz zcbenz approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
6-0-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@codebytere @zcbenz @ckerr @MarshallOfSound