Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boilerplate and Clis documentation is incorrect (electron-forge section) #19971

Closed
3 tasks done
ipoint-pgerhard opened this issue Aug 27, 2019 · 2 comments
Closed
3 tasks done

Comments

@ipoint-pgerhard
Copy link
Contributor

Preflight Checklist

  • I have read the Contributing Guidelines for this project.
  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

Currently the documentation related to electron-forge states

Forge comes with ready-to-use templates for popular frameworks like React, Vue, or Angular.

however this is not correct.
When opening the link the documentation shows that electron-forge no longer supports the listed frameworks. Instead a single template containing using webpack as a bundler is provided. I would suggest correcting this in the electron docs.

@ipoint-pgerhard
Copy link
Contributor Author

I changed the documentation and created a pull-request
#19975

@ckerr
Copy link
Member

ckerr commented Aug 30, 2019

Fixed in #19975.

@ckerr ckerr closed this as completed Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants