Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current page flashing while navigating to page with relative path and will-navigate event handler #20127

Closed
3 tasks done
AleshaOleg opened this issue Sep 5, 2019 · 2 comments

Comments

@AleshaOleg
Copy link

Preflight Checklist

  • I have read the Contributing Guidelines for this project.
  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

  • Electron Version:
    • v6.0.7
  • Operating System:
    • macOS 10.13.6
  • Last Known Working Electron version:
    • v6.0.3

Expected Behavior

Navigating to a page with a relative path and will-navigate event handler without any flashed.

Actual Behavior

Current page flashing while navigating to another page with relative path in href when will-navigate event handler exists.

To Reproduce

I made repository with reproducing - https://github.com/AleshaOleg/electron-flashing-page-reproduce

Please run it, and when you'll see GitHub home page, please click any link with relative path. For example, it's a green "Sign up" button.

Screenshots

https://www.dropbox.com/s/uhrmxzvzswjmqz2/Reproducing.mov?dl=0

Additional Information

Probably related to those fixes in 6.0.4:

  • Fixed web page displayed with offset when using native tab on macOS. #19888
  • Fixed white flash after restoring an app from the background. #19900
@MarshallOfSound
Copy link
Member

This issue is known and comes from upstream. Basically the renderer restarts on navigations and this causes the compositor to flash white. For instance I can see the white flash on 6.0.3 (in fact every version of Electron).

See #6104

You can mitigate this for same-site navigations by using app.allowRendererProcessReuse = true but you should read through what that property does before using it.

@fayeinmay
Copy link

Hey, sorry for asking here, but I crawled to many issues and couldn't find an answer. Is there any way to redirect between pages without having a "flash", except using allowRendererProcessReuse?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants