fix: add patch to node for native module size issue on windows #20627

deepak1556 · 2019-10-18T02:30:44Z

Backports #20614

PR description included and stakeholders cc'd
npm test passes
tests are changed or added
relevant documentation is changed or added
PR title follows semantic commit guidelines
PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Notes: fix native modules size increase with VC++ and node 12 on windows

release-clerk · 2019-10-18T16:57:12Z

Release Notes Persisted

fix native modules size increase with VC++ and node 12 on windows

fix: add patch to node for native module size issue on windows (#20614)

f42316d

deepak1556 requested a review from a team October 18, 2019 02:30

deepak1556 requested a review from a team as a code owner October 18, 2019 02:30

electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 18, 2019

trop bot mentioned this pull request Oct 18, 2019

fix: add patch to node for native module size issue on windows #20614

Merged

6 tasks

trop bot added 6-0-x backport This is a backport PR labels Oct 18, 2019

electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 18, 2019

zcbenz approved these changes Oct 18, 2019

View reviewed changes

jkleinsc approved these changes Oct 18, 2019

View reviewed changes

jkleinsc merged commit d5b088b into 6-0-x Oct 18, 2019

jkleinsc deleted the robo/fix_nm_size_6_x branch October 18, 2019 16:57

Provide feedback