fix: backport libuv patch for fs.mkdir/mkdirSync on invalid names #20664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
6 tasks
|
@deepak1556 This backport is not building. |
|
Updated, thanks! |
zcbenz
approved these changes
Oct 24, 2019
|
This PR requires @electron/wg-upgrades to approve. |
added 2 commits
October 29, 2019 15:34
jkleinsc
approved these changes
Oct 30, 2019
|
Merging as CI failure unrelated to PR change |
|
Release Notes Persisted
|
jkleinsc
deleted the
trop/5-0-x-bp-fix-backport-libuv-patch-for-fs-mkdir-mkdirsync-on-invalid-names-1571687057767
branch
pergy
pushed a commit
to pergy/electron
that referenced
this pull request
Jun 25, 2020
…ectron#20664) * fix: backport libuv patch for fs.mkdir/mkdirSync on invlaid names Backports libuv/libuv#2375 * chore: update patch path * ignore error on node install * fixup yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #20629
See that PR for details.
Notes: fix fs.mkdir/mkdirSync hang with {recursive: true} for invalid names with node 12 on windows