fix: send ELECTRON_BROWSER_CONTEXT_RELEASE asynchronously #20716

miniak · 2019-10-23T22:47:20Z

Backport of #20632

PR description included and stakeholders cc'd
npm test passes
tests are changed or added
PR title follows semantic commit guidelines
PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Notes: Fixed hang when closing a scriptable popup window using the remote module.

spec/api-remote-spec.js

release-clerk · 2019-10-29T02:34:15Z

Release Notes Persisted

Fixed hang when closing a scriptable popup window using the remote module.

miniak added backport This is a backport PR 6-1-x labels Oct 23, 2019

miniak self-assigned this Oct 23, 2019

trop bot mentioned this pull request Oct 23, 2019

fix: send ELECTRON_BROWSER_CONTEXT_RELEASE asynchronously #20632

Merged

5 tasks

zcbenz reviewed Oct 24, 2019

View reviewed changes

spec/api-remote-spec.js Show resolved Hide resolved

miniak added the wip ⚒ label Oct 24, 2019

miniak force-pushed the miniak/async-context-release-6-1-x branch from 0bff913 to 3ac6739 Compare October 24, 2019 09:50

zcbenz reviewed Oct 25, 2019

View reviewed changes

spec/api-remote-spec.js Outdated Show resolved Hide resolved

fix: send ELECTRON_BROWSER_CONTEXT_RELEASE asynchronously (#20632)

fb5e2cc

miniak force-pushed the miniak/async-context-release-6-1-x branch from 3ac6739 to fb5e2cc Compare October 28, 2019 19:56

miniak requested a review from zcbenz October 28, 2019 23:49

miniak removed the wip ⚒ label Oct 28, 2019

zcbenz approved these changes Oct 29, 2019

View reviewed changes

zcbenz merged commit 5127365 into 6-1-x Oct 29, 2019

zcbenz deleted the miniak/async-context-release-6-1-x branch October 29, 2019 02:34

Provide feedback